Skip to content

Commit

Permalink
win: manifest node.exe for Windows 8.1
Browse files Browse the repository at this point in the history
This is a port of 03e9352 .

Original commit message:

  Adding a compatibility section to node.exe embedded manifest so that
  Node is declared explicitly compatible with Windows 8.1. Required so
  that os.release() can return the correct version on Windows 8.1.

  See http://msdn.microsoft.com/en-us/library/windows/desktop/ms724451(v=vs.85).aspx

  Reviewed-by: Trevor Norris <[email protected]>

PR-URL: #2838
Reviewed-By: silverwind - Roman Reiss <[email protected]>
  • Loading branch information
orangemocha authored and joaocgreis committed Sep 16, 2015
1 parent e669b27 commit 8002192
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 0 deletions.
6 changes: 6 additions & 0 deletions node.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,12 @@
],
}],
],
'msvs_settings': {
'VCManifestTool': {
'EmbedManifest': 'true',
'AdditionalManifestFiles': 'src/res/node.exe.extra.manifest'
}
},
},
# generate ETW header and resource files
{
Expand Down
15 changes: 15 additions & 0 deletions src/res/node.exe.extra.manifest
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<?xml version='1.0' encoding='UTF-8' standalone='yes'?>
<assembly xmlns='urn:schemas-microsoft-com:asm.v1' manifestVersion='1.0'>
<compatibility xmlns="urn:schemas-microsoft-com:compatibility.v1">
<application>
<!-- Windows 8.1 -->
<supportedOS Id="{1f676c76-80e1-4239-95bb-83d0f6d0da78}"/>
<!-- Windows 8 -->
<supportedOS Id="{4a2f28e3-53b9-4441-ba9c-d69d4a4a6e38}"/>
<!-- Windows 7 -->
<supportedOS Id="{35138b9a-5d96-4fbd-8e2d-a2440225f93a}"/>
<!-- Windows Vista -->
<supportedOS Id="{e2011457-1546-43c5-a5fe-008deee3d3f0}"/>
</application>
</compatibility>
</assembly>

0 comments on commit 8002192

Please sign in to comment.