http2: simplify timeout tracking

There’s no need to reset the chunk counter for every write. Backport-PR-URL: #23774 PR-URL: #19206 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
nodejs · Oct 31, 2018 · 7f34c27 · 7f34c27
1 parent 18071db
commit 7f34c27
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 9 deletions.
diff --git a/src/node_http2.cc b/src/node_http2.cc
@@ -1798,10 +1798,6 @@ inline Http2Stream* Http2Session::SubmitRequest(
   return stream;
 }
 
-inline void Http2Session::SetChunksSinceLastWrite(size_t n) {
-  chunks_sent_since_last_write_ = n;
-}
-
 // Allocates the data buffer used to pass outbound data to the i/o stream.
 WriteWrap* Http2Session::AllocateSend() {
   HandleScope scope(env()->isolate());
@@ -2257,7 +2253,6 @@ inline int Http2Stream::DoWrite(WriteWrap* req_wrap,
   CHECK(!this->IsDestroyed());
   CHECK_EQ(send_handle, nullptr);
   Http2Scope h2scope(this);
-  session_->SetChunksSinceLastWrite();
   req_wrap->Dispatched();
   if (!IsWritable()) {
     req_wrap->Done(UV_EOF);
@@ -2751,8 +2746,6 @@ void Http2Stream::RespondFD(const FunctionCallbackInfo<Value>& args) {
   int64_t length = args[3]->IntegerValue(context).ToChecked();
   int options = args[4]->IntegerValue(context).ToChecked();
 
-  stream->session()->SetChunksSinceLastWrite();
-
   Headers list(isolate, context, headers);
   args.GetReturnValue().Set(stream->SubmitFile(fd, *list, list.length(),
                                                offset, length, options));

diff --git a/src/node_http2.h b/src/node_http2.h
@@ -815,8 +815,6 @@ class Http2Session : public AsyncWrap {
   // Write data to the session
   inline ssize_t Write(const uv_buf_t* bufs, size_t nbufs);
 
-  inline void SetChunksSinceLastWrite(size_t n = 0);
-
   size_t self_size() const override { return sizeof(*this); }
 
   char* stream_alloc() {