test: track callback invocations

Use `common.mustCall()` and `common.mustNotCall()` to check that callbacks are invoked the expected number of times in test-net-listen-shared-ports. PR-URL: #13010 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
nodejs · May 18, 2017 · 7e5ed8b · 7e5ed8b
1 parent 28ddac2
commit 7e5ed8b
Showing 1 changed file with 14 additions and 12 deletions.
diff --git a/test/sequential/test-net-listen-shared-ports.js b/test/sequential/test-net-listen-shared-ports.js
@@ -28,19 +28,19 @@ const net = require('net');
 if (cluster.isMaster) {
   const worker1 = cluster.fork();
 
-  worker1.on('message', function(msg) {
+  worker1.on('message', common.mustCall(function(msg) {
     assert.strictEqual(msg, 'success');
     const worker2 = cluster.fork();
 
-    worker2.on('message', function(msg) {
+    worker2.on('message', common.mustCall(function(msg) {
       assert.strictEqual(msg, 'server2:EADDRINUSE');
       worker1.kill();
       worker2.kill();
-    });
-  });
+    }));
+  }));
 } else {
-  const server1 = net.createServer(common.noop);
-  const server2 = net.createServer(common.noop);
+  const server1 = net.createServer(common.mustNotCall());
+  const server2 = net.createServer(common.mustNotCall());
 
   server1.on('error', function(err) {
     // no errors expected
@@ -56,10 +56,12 @@ if (cluster.isMaster) {
     host: 'localhost',
     port: common.PORT,
     exclusive: false
-  }, function() {
-    server2.listen({port: common.PORT + 1, exclusive: true}, function() {
-      // the first worker should succeed
-      process.send('success');
-    });
-  });
+  }, common.mustCall(function() {
+    server2.listen({port: common.PORT + 1, exclusive: true},
+                   common.mustCall(function() {
+                     // the first worker should succeed
+                     process.send('success');
+                   })
+    );
+  }));
 }