Skip to content

Commit

Permalink
doc,meta: allow Travis results for doc/comment changes
Browse files Browse the repository at this point in the history
Permit the use of Travis CI results for pull requests that only change
documentation or comments. This also removes
node-test-pull-request-lite-pipeline from the documentation. Efforts to
move all CI jobs to pipelines have stalled and it's not clear that our
current Jenkins admins are enthusiastic about pipelines.

PR-URL: #30330
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
  • Loading branch information
Trott authored and MylesBorins committed Nov 17, 2019
1 parent 401d2e9 commit 7ad2e02
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions COLLABORATOR_GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,9 @@ the comment anyway to avoid any doubt.
All fixes must have a test case which demonstrates the defect. The test should
fail before the change, and pass after the change.

All pull requests must pass continuous integration tests on the
[project CI server](https://ci.nodejs.org/).
All pull requests must pass continuous integration tests. Code changes must pass
on [project CI server](https://ci.nodejs.org/). Pull requests that only change
documentation and comments can use Travis CI results.

Do not land any pull requests without passing (green or yellow) CI runs. If
there are CI failures unrelated to the change in the pull request, try "Resume
Expand All @@ -187,10 +188,6 @@ everything else.
is the CI job to test pull requests. It runs the `build-ci` and `test-ci`
targets on all supported platforms.

* [`node-test-pull-request-lite-pipeline`](https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/)
runs the linter job. It also runs the tests on a very fast host. This is useful
for changes that only affect comments or documentation.

* [`citgm-smoker`](https://ci.nodejs.org/job/citgm-smoker/)
uses [`CitGM`](https://github.com/nodejs/citgm) to allow you to run
`npm install && npm test` on a large selection of common modules. This is
Expand Down

0 comments on commit 7ad2e02

Please sign in to comment.