crypto: don't call callback twice in case crypto.randomBytes fails

PR-URL: #40157 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
nodejs · Oct 4, 2021 · 7968c79 · 7968c79
1 parent 94b415b
commit 7968c79
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/lib/internal/crypto/random.js b/lib/internal/crypto/random.js
@@ -102,7 +102,7 @@ function randomBytes(size, callback) {
 
   // Keep the callback as a regular function so this is propagated.
   randomFill(buf.buffer, 0, size, function(error) {
-    if (error) FunctionPrototypeCall(callback, this, error);
+    if (error) return FunctionPrototypeCall(callback, this, error);
     FunctionPrototypeCall(callback, this, null, buf);
   });
 }