workers: fix spawning from preload scripts

Fix spawning nested worker threads from preload scripts and warn about doing so. Signed-off-by: James M Snell <[email protected]> Fixes: #36531 PR-URL: #37481 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
nodejs · May 1, 2021 · 78ad8b4 · 78ad8b4
1 parent 52c0f0b
commit 78ad8b4
Show file tree

Hide file tree

Showing 4 changed files with 35 additions and 4 deletions.
diff --git a/doc/api/worker_threads.md b/doc/api/worker_threads.md
@@ -966,6 +966,17 @@ Calling `unref()` on a worker will allow the thread to exit if this is the only
 active handle in the event system. If the worker is already `unref()`ed calling
 `unref()` again will have no effect.
 
+## Notes
+
+### Launching worker threads from preload scripts
+
+Take care when launching worker threads from preload scripts (scripts loaded
+and run using the `-r` command line flag). Unless the `execArgv` option is
+explicitly set, new Worker threads automatically inherit the command line flags
+from the running process and will preload the same preload scripts as the main
+thread. If the preload script unconditionally launches a worker thread, every
+thread spawned will spawn another until the application crashes.
+
 [Addons worker support]: addons.md#addons_worker_support
 [ECMAScript module loader]: esm.md#esm_data_imports
 [HTML structured clone algorithm]: https://developer.mozilla.org/en-US/docs/Web/API/Web_Workers_API/Structured_clone_algorithm

diff --git a/lib/internal/main/worker_thread.js b/lib/internal/main/worker_thread.js
@@ -119,10 +119,6 @@ port.on('message', (message) => {
     initializeCJSLoader();
     initializeESMLoader();
 
-    const CJSLoader = require('internal/modules/cjs/loader');
-    assert(!CJSLoader.hasLoadedAnyUserCJSModule);
-    loadPreloadModules();
-    initializeFrozenIntrinsics();
     if (argv !== undefined) {
       process.argv = process.argv.concat(argv);
     }
@@ -145,6 +141,11 @@ port.on('message', (message) => {
     };
     workerIo.sharedCwdCounter = cwdCounter;
 
+    const CJSLoader = require('internal/modules/cjs/loader');
+    assert(!CJSLoader.hasLoadedAnyUserCJSModule);
+    loadPreloadModules();
+    initializeFrozenIntrinsics();
+
     if (!hasStdin)
       process.stdin.push(null);
 

diff --git a/test/fixtures/worker-preload.js b/test/fixtures/worker-preload.js
@@ -0,0 +1,9 @@
+const {
+  Worker,
+  workerData,
+  threadId
+} = require('worker_threads');
+
+if (threadId < 2) {
+  new Worker('1 + 1', { eval: true });
+}
diff --git a/test/parallel/test-preload-worker.js b/test/parallel/test-preload-worker.js
@@ -0,0 +1,10 @@
+'use strict';
+
+const common = require('../common');
+const fixtures = require('../common/fixtures');
+const worker = fixtures.path('worker-preload.js');
+const { exec } = require('child_process');
+const kNodeBinary = process.argv[0];
+
+
+exec(`"${kNodeBinary}" -r "${worker}" -pe "1+1"`, common.mustSucceed());