From 785211702a5ab72d61cd94d4f18b2807999390bf Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Tue, 28 Jun 2016 21:21:21 +0200 Subject: [PATCH] src: fix readability/inheritance cpplint warnings PR-URL: https://github.com/nodejs/node/pull/7462 Reviewed-By: Trevor Norris --- src/async-wrap.cc | 10 +++++----- src/cares_wrap.cc | 2 +- src/fs_event_wrap.cc | 2 +- src/handle_wrap.h | 2 +- src/node_stat_watcher.h | 2 +- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/async-wrap.cc b/src/async-wrap.cc index 2b6839c05ee461..1a4ef67b6896d6 100644 --- a/src/async-wrap.cc +++ b/src/async-wrap.cc @@ -39,11 +39,11 @@ class RetainedAsyncInfo: public RetainedObjectInfo { public: explicit RetainedAsyncInfo(uint16_t class_id, AsyncWrap* wrap); - virtual void Dispose() override; - virtual bool IsEquivalent(RetainedObjectInfo* other) override; - virtual intptr_t GetHash() override; - virtual const char* GetLabel() override; - virtual intptr_t GetSizeInBytes() override; + void Dispose() override; + bool IsEquivalent(RetainedObjectInfo* other) override; + intptr_t GetHash() override; + const char* GetLabel() override; + intptr_t GetSizeInBytes() override; private: const char* label_; diff --git a/src/cares_wrap.cc b/src/cares_wrap.cc index ddb215715cb2c4..7f2a18e1d5f463 100644 --- a/src/cares_wrap.cc +++ b/src/cares_wrap.cc @@ -256,7 +256,7 @@ class QueryWrap : public AsyncWrap { req_wrap_obj->Set(env->domain_string(), env->domain_array()->Get(0)); } - virtual ~QueryWrap() override { + ~QueryWrap() override { CHECK_EQ(false, persistent().IsEmpty()); persistent().Reset(); } diff --git a/src/fs_event_wrap.cc b/src/fs_event_wrap.cc index cd6dc417ba2460..9d96cd51a24cee 100644 --- a/src/fs_event_wrap.cc +++ b/src/fs_event_wrap.cc @@ -34,7 +34,7 @@ class FSEventWrap: public HandleWrap { private: FSEventWrap(Environment* env, Local object); - virtual ~FSEventWrap() override; + ~FSEventWrap() override; static void OnEvent(uv_fs_event_t* handle, const char* filename, int events, int status); diff --git a/src/handle_wrap.h b/src/handle_wrap.h index da712b33befbcc..2ed5957c50a8c0 100644 --- a/src/handle_wrap.h +++ b/src/handle_wrap.h @@ -48,7 +48,7 @@ class HandleWrap : public AsyncWrap { uv_handle_t* handle, AsyncWrap::ProviderType provider, AsyncWrap* parent = nullptr); - virtual ~HandleWrap() override; + ~HandleWrap() override; private: friend class Environment; diff --git a/src/node_stat_watcher.h b/src/node_stat_watcher.h index bc7929880b26f7..ea96c0247f6ab0 100644 --- a/src/node_stat_watcher.h +++ b/src/node_stat_watcher.h @@ -11,7 +11,7 @@ namespace node { class StatWatcher : public AsyncWrap { public: - virtual ~StatWatcher() override; + ~StatWatcher() override; static void Initialize(Environment* env, v8::Local target);