From 74a6929938814b6da5c874f3640712a695536803 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Thu, 13 Apr 2017 12:42:56 +0200 Subject: [PATCH] doc: upgrade Clang requirement to 3.4.2 Clang 3.4.1 has a bug that prevents compilation of V8. As of Node.js 8.0.0 we stopped floating a workaround for this issue. PR-URL: https://github.com/nodejs/node/pull/12388 Reviewed-By: Ben Noordhuis Reviewed-By: Colin Ihrig Reviewed-By: Benjamin Gruenbaum Reviewed-By: James M Snell Reviewed-By: Gibson Fahnestock --- BUILDING.md | 6 +++--- configure | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/BUILDING.md b/BUILDING.md index 979908b2150bc6..fb00ac6dc647dc 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -62,8 +62,8 @@ Depending on host platform, the selection of toolchains may vary. #### Unix -* GCC 4.8 or newer -* Clang 3.4 or newer +* GCC 4.8.5 or newer +* Clang 3.4.2 or newer #### Windows @@ -78,7 +78,7 @@ Depending on host platform, the selection of toolchains may vary. Prerequisites: * `gcc` and `g++` 4.8.5 or newer, or -* `clang` and `clang++` 3.4 or newer +* `clang` and `clang++` 3.4.2 or newer * Python 2.6 or 2.7 * GNU Make 3.81 or newer diff --git a/configure b/configure index 5232ccefdb1606..090c90c87c653e 100755 --- a/configure +++ b/configure @@ -617,8 +617,8 @@ def check_compiler(o): ok, is_clang, clang_version, gcc_version = try_check_compiler(CXX, 'c++') if not ok: warn('failed to autodetect C++ compiler version (CXX=%s)' % CXX) - elif clang_version < '3.4.0' if is_clang else gcc_version < '4.8.0': - warn('C++ compiler too old, need g++ 4.8 or clang++ 3.4 (CXX=%s)' % CXX) + elif clang_version < '3.4.2' if is_clang else gcc_version < '4.8.0': + warn('C++ compiler too old, need g++ 4.8 or clang++ 3.4.2 (CXX=%s)' % CXX) ok, is_clang, clang_version, gcc_version = try_check_compiler(CC, 'c') if not ok: