node-api: add warning suppression for NAPI_EXPERIMENTAL

Author: miguelmarcondesf

src/js_native_api.h

@@ -21,6 +21,10 @@
 #endif
 #endif
 
+#if defined(NAPI_EXPERIMENTAL) && !defined(NODE_API_EXPERIMENTAL_NO_WARNING)
+#warning "NAPI_EXPERIMENTAL is enabled. Experimental features may be unstable."
+#endif
+
 #include "js_native_api_types.h"
 
 // If you need __declspec(dllimport), either include <node_api.h> instead, or
@@ -536,8 +540,6 @@ node_api_post_finalizer(node_api_basic_env env,
                         void* finalize_data,
                         void* finalize_hint);
 
-#warning "NAPI_EXPERIMENTAL is enabled. Experimental features may be unstable."
-
 #endif  // NAPI_EXPERIMENTAL
 
 #if NAPI_VERSION >= 6

src/node_api.h

@@ -266,10 +266,4 @@ node_api_get_module_file_name(node_api_basic_env env, const char** result);
 
 EXTERN_C_END
 
-#ifdef NAPI_EXPERIMENTAL
-
-#warning "NAPI_EXPERIMENTAL is enabled. Experimental features may be unstable."
-
-#endif  // NAPI_EXPERIMENTAL
-
 #endif  // SRC_NODE_API_H_

test/addons/hello-world/binding.gyp

@@ -9,12 +9,6 @@
       'target_name': 'binding2',
       'sources': [ 'binding2.cc' ],
       'includes': ['../common.gypi'],
-    },
-    {
-      'target_name': 'binding_experimental',
-      'sources': [ 'binding_experimental.cc' ],
-      'includes': ['../common.gypi'],
-      'defines': [ 'NAPI_EXPERIMENTAL' ],
     }
   ]
 }

test/addons/hello-world/binding_experimental.cc

@@ -14,7 +14,3 @@ delete require.cache[bindingPath];
 const rebinding = require(bindingPath);
 assert.strictEqual(rebinding.hello(), 'world');
 assert.notStrictEqual(binding.hello, rebinding.hello);
-
-const binding_experimental = require(require.resolve(`./build/${common.buildType}/binding_experimental`));
-assert.strictEqual(binding_experimental.hello(), 'world');
-console.log('binding_experimental.hello() =', binding_experimental.hello());