test: warn when inspector process crashes

If the subprocess being inspected hard crashes, there will be no information on the log, and the parent process will just wait until timeout. Logging the error signal when it happens can help developers understand failures faster. Signed-off-by: Matheus Marchini <[email protected]> PR-URL: #32133 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Mar 9, 2020 · 6f9f2c5 · 6f9f2c5
1 parent 710c905
commit 6f9f2c5
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/test/common/inspector-helper.js b/test/common/inspector-helper.js
@@ -344,6 +344,9 @@ class NodeInstance extends EventEmitter {
 
     this._shutdownPromise = new Promise((resolve) => {
       this._process.once('exit', (exitCode, signal) => {
+        if (signal) {
+          console.error(`[err] child process crashed, signal ${signal}`);
+        }
         resolve({ exitCode, signal });
         this._running = false;
       });