Skip to content

Commit

Permalink
doc: update tags in adding-new-napi-api.md
Browse files Browse the repository at this point in the history
The tag is now renamed as "node-api".

PR-URL: #44190
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
  • Loading branch information
legendecas authored and ruyadorno committed Aug 22, 2022
1 parent b9fd240 commit 6bff14b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions doc/contributing/adding-new-napi-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Node-API.
ABI compatibility with other versions of Node.js.
* New API **should** be agnostic towards the underlying JavaScript VM.
* New API PRs **must** have a corresponding documentation update.
* New API PRs **must** be tagged as **n-api**.
* New API PRs **must** be tagged as **node-api**.
* There **must** be at least one test case showing how to use the API.
* There **should** be at least one test case per interesting use of the API.
* There **should** be a sample provided that operates in a realistic way
Expand All @@ -38,7 +38,7 @@ Node-API.
* Experimental status exit criteria **must** involve at least the
following:
* A new PR **must** be opened in `nodejs/node` to remove experimental
status. This PR **must** be tagged as **n-api** and **semver-minor**.
status. This PR **must** be tagged as **node-api** and **semver-minor**.
* Exiting an API from experimental **must** be signed off by the team.
* If a backport is merited, an API **must** have a down-level
implementation.
Expand Down

0 comments on commit 6bff14b

Please sign in to comment.