timers: check for immediate instance in clearImmediate

PR-URL: #57069
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>

Author: gurgunday

lib/timers.js

@@ -301,7 +301,7 @@ ObjectDefineProperty(setImmediate, customPromisify, {
  * @returns {void}
  */
 function clearImmediate(immediate) {
-  if (!immediate || immediate._destroyed)
+  if (!immediate?._onImmediate || immediate._destroyed)
     return;
 
   immediateInfo[kCount]--;

test/parallel/test-timers-invalid-clear.js

@@ -0,0 +1,13 @@
+'use strict';
+
+const common = require('../common');
+
+// clearImmediate should be a noop if anything other than an Immediate
+// is passed to it.
+
+const t = setTimeout(common.mustCall());
+
+clearImmediate(t);
+
+setTimeout(common.mustCall());
+setTimeout(common.mustCall());