Skip to content

Commit

Permalink
src: wrap source before doing syntax check
Browse files Browse the repository at this point in the history
This is to ensure that it is evaluated the same way it would be if it
were to be run by node or required.

Before, the following would pass if run by node, but fail if run via
the syntax check flag:

    if (true) {
      return;
    }

Now, this will pass the syntax check

PR-URL: #3587
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
  • Loading branch information
evanlucas authored and rvagg committed Nov 6, 2015
1 parent 1e98d90 commit 65cd03c
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/node.js
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,8 @@
var source = fs.readFileSync(filename, 'utf-8');
// remove shebang and BOM
source = internalModule.stripBOM(source.replace(/^\#\!.*/, ''));
// wrap it
source = Module.wrap(source);
// compile the script, this will throw if it fails
new vm.Script(source, {filename: filename, displayErrors: true});
process.exit(0);
Expand Down
3 changes: 3 additions & 0 deletions test/fixtures/syntax/illegal_if_not_wrapped.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
if (true) {
return;
}
1 change: 1 addition & 0 deletions test/parallel/test-cli-syntax.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ var syntaxArgs = [
'syntax/good_syntax',
'syntax/good_syntax_shebang.js',
'syntax/good_syntax_shebang',
'syntax/illegal_if_not_wrapped.js'
].forEach(function(file) {
file = path.join(common.fixturesDir, file);

Expand Down

0 comments on commit 65cd03c

Please sign in to comment.