net: emit close on unconnected socket

Socket should always emit 'close'. Regardless whether it has been connected or not. PR-URL: #29803 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
nodejs · Oct 9, 2019 · 65c4752 · 65c4752
1 parent 20896f7
commit 65c4752
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/lib/net.js b/lib/net.js
@@ -660,10 +660,12 @@ Socket.prototype._destroy = function(exception, cb) {
     this._handle.onread = noop;
     this._handle = null;
     this._sockname = null;
+    cb(exception);
+  } else {
+    cb(exception);
+    process.nextTick(emitCloseNT, this);
   }
 
-  cb(exception);
-
   if (this._server) {
     debug('has server');
     this._server._connections--;

diff --git a/test/parallel/test-net-connect-destroy.js b/test/parallel/test-net-connect-destroy.js
@@ -0,0 +1,7 @@
+'use strict';
+const common = require('../common');
+const net = require('net');
+
+const socket = new net.Socket();
+socket.on('close', common.mustCall());
+socket.destroy();