doc: improve best practices in onboarding-extras

PR-URL: #19315 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
nodejs · Oct 17, 2018 · 610297e · 610297e
1 parent afcf059
commit 610297e
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/doc/onboarding-extras.md b/doc/onboarding-extras.md
@@ -130,10 +130,7 @@ to update from nodejs/node:
 * `git remote update -p` OR `git fetch --all` (I prefer the former)
 * `git merge --ff-only upstream/master` (or `REMOTENAME/BRANCH`)
 
+## Best practices
 
-## best practices
-
-* commit often, out to your github fork (origin), open a PR
-* when making PRs make sure to spend time on the description:
-  * every moment you spend writing a good description quarters the amount of time it takes to understand your code.
-* usually prefer to only squash at the *end* of your work, depends on the change
+* When making PRs, spend time writing a thorough description.
+* Usually only squash at the end of your work.