From 5aafc52a418dfae4272adb023ee0c3e4b00982e3 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Mon, 5 Jun 2017 11:58:20 +0200 Subject: [PATCH] buffer: add constants object MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add `buffer.constants`, containing length limits for `Buffer` and `string` instances. This could be useful for programmers to tell whether a value can be turned into a string or not. Ref: https://github.com/nodejs/node/issues/13465 PR-URL: https://github.com/nodejs/node/pull/13467 Reviewed-By: Colin Ihrig Reviewed-By: Vse Mozhet Byt Reviewed-By: Tobias Nießen --- doc/api/buffer.md | 61 +++++++++++++++++++++----- lib/buffer.js | 23 ++++++++++ test/parallel/test-buffer-constants.js | 13 ++++++ 3 files changed, 85 insertions(+), 12 deletions(-) create mode 100644 test/parallel/test-buffer-constants.js diff --git a/doc/api/buffer.md b/doc/api/buffer.md index 5de805b6e9831e..4488ae2ad9bf8d 100644 --- a/doc/api/buffer.md +++ b/doc/api/buffer.md @@ -447,8 +447,8 @@ changes: * `size` {integer} The desired length of the new `Buffer` Allocates a new `Buffer` of `size` bytes. If the `size` is larger than -[`buffer.kMaxLength`] or smaller than 0, a [`RangeError`] will be thrown. -A zero-length `Buffer` will be created if `size` is 0. +[`buffer.constants.MAX_LENGTH`] or smaller than 0, a [`RangeError`] will be +thrown. A zero-length `Buffer` will be created if `size` is 0. Prior to Node.js 8.0.0, the underlying memory for `Buffer` instances created in this way is *not initialized*. The contents of a newly created @@ -528,8 +528,8 @@ console.log(buf); ``` Allocates a new `Buffer` of `size` bytes. If the `size` is larger than -[`buffer.kMaxLength`] or smaller than 0, a [`RangeError`] will be thrown. -A zero-length `Buffer` will be created if `size` is 0. +[`buffer.constants.MAX_LENGTH`] or smaller than 0, a [`RangeError`] will be +thrown. A zero-length `Buffer` will be created if `size` is 0. If `fill` is specified, the allocated `Buffer` will be initialized by calling [`buf.fill(fill)`][`buf.fill()`]. @@ -573,8 +573,8 @@ changes: * `size` {integer} The desired length of the new `Buffer` Allocates a new `Buffer` of `size` bytes. If the `size` is larger than -[`buffer.kMaxLength`] or smaller than 0, a [`RangeError`] will be thrown. -A zero-length `Buffer` will be created if `size` is 0. +[`buffer.constants.MAX_LENGTH`] or smaller than 0, a [`RangeError`] will be +thrown. A zero-length `Buffer` will be created if `size` is 0. The underlying memory for `Buffer` instances created in this way is *not initialized*. The contents of the newly created `Buffer` are unknown and @@ -619,8 +619,8 @@ added: v5.10.0 * `size` {integer} The desired length of the new `Buffer` Allocates a new `Buffer` of `size` bytes. If the `size` is larger than -[`buffer.kMaxLength`] or smaller than 0, a [`RangeError`] will be thrown. -A zero-length `Buffer` will be created if `size` is 0. +[`buffer.constants.MAX_LENGTH`] or smaller than 0, a [`RangeError`] will be +thrown. A zero-length `Buffer` will be created if `size` is 0. The underlying memory for `Buffer` instances created in this way is *not initialized*. The contents of the newly created `Buffer` are unknown and @@ -2050,6 +2050,9 @@ added: v0.1.90 Decodes `buf` to a string according to the specified character encoding in `encoding`. `start` and `end` may be passed to decode only a subset of `buf`. +The maximum length of a string instance (in UTF-16 code units) is available +as [`buffer.constants.MAX_STRING_LENGTH`][]. + Examples: ```js @@ -2507,8 +2510,7 @@ added: v3.0.0 * {integer} The largest size allowed for a single `Buffer` instance -On 32-bit architectures, this value is `(2^30)-1` (~1GB). -On 64-bit architectures, this value is `(2^31)-1` (~2GB). +An alias for [`buffer.constants.MAX_LENGTH`][] Note that this is a property on the `buffer` module returned by `require('buffer')`, not on the `Buffer` global or a `Buffer` instance. @@ -2599,8 +2601,8 @@ deprecated: v6.0.0 * `size` {integer} The desired length of the new `SlowBuffer` Allocates a new `Buffer` of `size` bytes. If the `size` is larger than -[`buffer.kMaxLength`] or smaller than 0, a [`RangeError`] will be thrown. -A zero-length `Buffer` will be created if `size` is 0. +[`buffer.constants.MAX_LENGTH`] or smaller than 0, a [`RangeError`] will be +thrown. A zero-length `Buffer` will be created if `size` is 0. The underlying memory for `SlowBuffer` instances is *not initialized*. The contents of a newly created `SlowBuffer` are unknown and may contain @@ -2622,6 +2624,39 @@ buf.fill(0); console.log(buf); ``` + +## Buffer Constants + + +Note that `buffer.constants` is a property on the `buffer` module returned by +`require('buffer')`, not on the `Buffer` global or a `Buffer` instance. + +### buffer.constants.MAX_LENGTH + + +* {integer} The largest size allowed for a single `Buffer` instance + +On 32-bit architectures, this value is `(2^30)-1` (~1GB). +On 64-bit architectures, this value is `(2^31)-1` (~2GB). + +This value is also available as [`buffer.kMaxLength`][]. + +### buffer.constants.MAX_STRING_LENGTH + + +* {integer} The largest length allowed for a single `string` instance + +Represents the largest `length` that a `string` primitive can have, counted +in UTF-16 code units. + +This value may depend on the JS engine that is being used. + [`ArrayBuffer#slice()`]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/ArrayBuffer/slice [`ArrayBuffer`]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/ArrayBuffer [`Buffer.alloc()`]: #buffer_class_method_buffer_alloc_size_fill_encoding @@ -2652,6 +2687,8 @@ console.log(buf); [`buf.slice()`]: #buffer_buf_slice_start_end [`buf.values()`]: #buffer_buf_values [`buffer.kMaxLength`]: #buffer_buffer_kmaxlength +[`buffer.constants.MAX_LENGTH`]: #buffer_buffer_constants_max_length +[`buffer.constants.MAX_STRING_LENGTH`]: #buffer_buffer_constants_max_string_length [`util.inspect()`]: util.html#util_util_inspect_object_options [RFC1345]: https://tools.ietf.org/html/rfc1345 [RFC4648, Section 5]: https://tools.ietf.org/html/rfc4648#section-5 diff --git a/lib/buffer.js b/lib/buffer.js index 168a607a36270c..223b6eed24e350 100644 --- a/lib/buffer.js +++ b/lib/buffer.js @@ -41,8 +41,31 @@ Buffer.prototype = FastBuffer.prototype; exports.Buffer = Buffer; exports.SlowBuffer = SlowBuffer; exports.INSPECT_MAX_BYTES = 50; + +// Legacy. exports.kMaxLength = binding.kMaxLength; +const constants = Object.defineProperties({}, { + MAX_LENGTH: { + value: binding.kStringMaxLength, + writable: false, + enumerable: true + }, + MAX_STRING_LENGTH: { + value: binding.kStringMaxLength, + writable: false, + enumerable: true + } +}); + +Object.defineProperty(exports, 'constants', { + configurable: false, + enumerable: true, + value: constants +}); + +exports.kStringMaxLength = binding.kStringMaxLength; + const kFromErrorMsg = 'First argument must be a string, Buffer, ' + 'ArrayBuffer, Array, or array-like object.'; diff --git a/test/parallel/test-buffer-constants.js b/test/parallel/test-buffer-constants.js new file mode 100644 index 00000000000000..59f5b6d0deada4 --- /dev/null +++ b/test/parallel/test-buffer-constants.js @@ -0,0 +1,13 @@ +'use strict'; +require('../common'); +const assert = require('assert'); + +const { MAX_LENGTH, MAX_STRING_LENGTH } = require('buffer').constants; + +assert.strictEqual(typeof MAX_LENGTH, 'number'); +assert.strictEqual(typeof MAX_STRING_LENGTH, 'number'); +assert(MAX_STRING_LENGTH <= MAX_LENGTH); +assert.throws(() => ' '.repeat(MAX_STRING_LENGTH + 1), + /^RangeError: Invalid string length$/); + +assert.doesNotThrow(() => ' '.repeat(MAX_STRING_LENGTH));