From 5a637e9d369264d109d560300bc376800570b8c8 Mon Sep 17 00:00:00 2001 From: raisinten Date: Mon, 16 Nov 2020 18:18:38 +0530 Subject: [PATCH] src: remove empty name check in node_env_var.cc The empty name check has been removed since this has landed: https://github.com/libuv/libuv/pull/2473 PR-URL: https://github.com/nodejs/node/pull/36133 Reviewed-By: Anna Henningsen Reviewed-By: Rich Trott Reviewed-By: James M Snell --- src/node_env_var.cc | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/node_env_var.cc b/src/node_env_var.cc index 45f2967f4b0eb7..e6d9573ca7ccef 100644 --- a/src/node_env_var.cc +++ b/src/node_env_var.cc @@ -179,9 +179,7 @@ Local RealEnvStore::Enumerate(Isolate* isolate) const { for (int i = 0; i < count; i++) { #ifdef _WIN32 // If the key starts with '=' it is a hidden environment variable. - // The '\0' check is a workaround for the bug behind - // https://github.com/libuv/libuv/pull/2473 and can be removed later. - if (items[i].name[0] == '=' || items[i].name[0] == '\0') continue; + if (items[i].name[0] == '=') continue; #endif MaybeLocal str = String::NewFromUtf8(isolate, items[i].name); if (str.IsEmpty()) {