From 56e29768158ef40700c4133395a30cae8775f2d9 Mon Sep 17 00:00:00 2001
From: Filip Skokan <panva.ip@gmail.com>
Date: Mon, 10 May 2021 12:33:11 +0200
Subject: [PATCH] crypto: expose KeyObject.isKeyObject(obj) and
 KeyObject.isCryptoKey(obj)

closes #38611
---
 doc/api/crypto.md                        | 20 ++++++++++++++++++++
 lib/internal/crypto/keys.js              | 12 ++++++++++--
 test/parallel/test-crypto-key-objects.js | 24 +++++++++++++++++++++++-
 test/parallel/test-webcrypto-keygen.js   | 23 ++++++++++++++++++++++-
 4 files changed, 75 insertions(+), 4 deletions(-)

diff --git a/doc/api/crypto.md b/doc/api/crypto.md
index 9b4559473ca7e5..a08d04ec34ef8b 100644
--- a/doc/api/crypto.md
+++ b/doc/api/crypto.md
@@ -1902,6 +1902,26 @@ const {
 })();
 ```
 
+### Static method: `KeyObject.isCryptoKey(obj)`
+<!-- YAML
+added: REPLACEME
+-->
+
+* `obj` {Object}
+* Returns: {boolean}
+
+Returns `true` if `obj` is a {CryptoKey}, `false` otherwise.
+
+### Static method: `KeyObject.isKeyObject(obj)`
+<!-- YAML
+added: REPLACEME
+-->
+
+* `obj` {Object}
+* Returns: {boolean}
+
+Returns `true` if `obj` is a {KeyObject}, `false` otherwise.
+
 ### `keyObject.asymmetricKeyDetails`
 <!-- YAML
 added: v15.7.0
diff --git a/lib/internal/crypto/keys.js b/lib/internal/crypto/keys.js
index cc5b00a16ee021..78a0a13c1ccc48 100644
--- a/lib/internal/crypto/keys.js
+++ b/lib/internal/crypto/keys.js
@@ -116,6 +116,14 @@ const {
       });
     }
 
+    static isCryptoKey(obj) {
+      return isCryptoKey(obj);
+    }
+
+    static isKeyObject(obj) {
+      return isKeyObject(obj);
+    }
+
     get type() {
       return this[kKeyType];
     }
@@ -639,8 +647,8 @@ function createPrivateKey(key) {
   return new PrivateKeyObject(handle);
 }
 
-function isKeyObject(key) {
-  return key instanceof KeyObject;
+function isKeyObject(obj) {
+  return obj != null && obj[kHandle] !== undefined;
 }
 
 // Our implementation of CryptoKey is a simple wrapper around a KeyObject
diff --git a/test/parallel/test-crypto-key-objects.js b/test/parallel/test-crypto-key-objects.js
index d7b3f9af83acd9..62270c4dad095b 100644
--- a/test/parallel/test-crypto-key-objects.js
+++ b/test/parallel/test-crypto-key-objects.js
@@ -20,7 +20,8 @@ const {
   privateDecrypt,
   privateEncrypt,
   getCurves,
-  generateKeyPairSync
+  generateKeyPairSync,
+  webcrypto,
 } = require('crypto');
 
 const fixtures = require('../common/fixtures');
@@ -757,3 +758,24 @@ const privateDsa = fixtures.readKey('dsa_private_encrypted_1025.pem',
       message: `Unsupported JWK EC curve: ${namedCurve}.`
     });
 }
+
+{
+  const buffer = Buffer.from('Hello World');
+  const keyObject = createSecretKey(buffer);
+  const keyPair = generateKeyPairSync('ec', { namedCurve: 'P-256' });
+  assert(KeyObject.isKeyObject(keyPair.publicKey));
+  assert(KeyObject.isKeyObject(keyPair.privateKey));
+  assert(KeyObject.isKeyObject(keyObject));
+
+  assert(!KeyObject.isKeyObject(buffer));
+
+  webcrypto.subtle.importKey(
+    'node.keyObject',
+    keyPair.publicKey,
+    { name: 'ECDH', namedCurve: 'P-256' },
+    false,
+    [],
+  ).then((cryptoKey) => {
+    assert(!KeyObject.isKeyObject(cryptoKey));
+  });
+}
diff --git a/test/parallel/test-webcrypto-keygen.js b/test/parallel/test-webcrypto-keygen.js
index 1a48d6761c72db..e42386c2e403e9 100644
--- a/test/parallel/test-webcrypto-keygen.js
+++ b/test/parallel/test-webcrypto-keygen.js
@@ -6,7 +6,11 @@ if (!common.hasCrypto)
   common.skip('missing crypto');
 
 const assert = require('assert');
-const { subtle, CryptoKey } = require('crypto').webcrypto;
+const {
+  KeyObject,
+  webcrypto: { subtle, CryptoKey },
+  createSecretKey,
+} = require('crypto');
 
 const allUsages = [
   'encrypt',
@@ -220,6 +224,8 @@ const vectors = {
 
     assert(publicKey);
     assert(privateKey);
+    assert(KeyObject.isCryptoKey(publicKey));
+    assert(KeyObject.isCryptoKey(privateKey));
 
     assert(publicKey instanceof CryptoKey);
     assert(privateKey instanceof CryptoKey);
@@ -366,6 +372,8 @@ const vectors = {
 
     assert(publicKey);
     assert(privateKey);
+    assert(KeyObject.isCryptoKey(publicKey));
+    assert(KeyObject.isCryptoKey(privateKey));
 
     assert.strictEqual(publicKey.type, 'public');
     assert.strictEqual(privateKey.type, 'private');
@@ -430,6 +438,7 @@ const vectors = {
     }, true, usages);
 
     assert(key);
+    assert(KeyObject.isCryptoKey(key));
 
     assert.strictEqual(key.type, 'secret');
     assert.strictEqual(key.extractable, true);
@@ -488,6 +497,7 @@ const vectors = {
     }
 
     assert(key);
+    assert(KeyObject.isCryptoKey(key));
 
     assert.strictEqual(key.type, 'secret');
     assert.strictEqual(key.extractable, true);
@@ -544,6 +554,8 @@ const vectors = {
 
     assert(publicKey);
     assert(privateKey);
+    assert(KeyObject.isCryptoKey(publicKey));
+    assert(KeyObject.isCryptoKey(privateKey));
 
     assert.strictEqual(publicKey.type, 'public');
     assert.strictEqual(privateKey.type, 'private');
@@ -634,6 +646,8 @@ const vectors = {
     }, true, ['deriveKey']);
   assert(publicKey);
   assert(privateKey);
+  assert(KeyObject.isCryptoKey(publicKey));
+  assert(KeyObject.isCryptoKey(privateKey));
   assert.strictEqual(publicKey.type, 'public');
   assert.strictEqual(privateKey.type, 'private');
   assert.strictEqual(publicKey.algorithm.name, 'NODE-DH');
@@ -646,3 +660,10 @@ const vectors = {
 assert.throws(() => new CryptoKey(), {
   code: 'ERR_OPERATION_FAILED'
 });
+
+{
+  const buffer = Buffer.from('Hello World');
+  const keyObject = createSecretKey(buffer);
+  assert(!KeyObject.isCryptoKey(buffer));
+  assert(!KeyObject.isCryptoKey(keyObject));
+}