assert: remove unreachable code

In lib/internal/assert/assertion_error.js, line 391 assures that `operator` is 'deepEqual' so there is no need to check the value of `operator` in a ternary on the next line (line 392). Remove the ternary. PR-URL: #27786 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · May 28, 2019 · 530e63a · 530e63a
1 parent d774ea5
commit 530e63a
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/lib/internal/assert/assertion_error.js b/lib/internal/assert/assertion_error.js
@@ -374,9 +374,9 @@ class AssertionError extends Error {
       } else {
         let res = inspectValue(actual);
         let other = inspectValue(expected);
-        const knownOperators = kReadableOperator[operator];
+        const knownOperator = kReadableOperator[operator];
         if (operator === 'notDeepEqual' && res === other) {
-          res = `${knownOperators}\n\n${res}`;
+          res = `${knownOperator}\n\n${res}`;
           if (res.length > 1024) {
             res = `${res.slice(0, 1021)}...`;
           }
@@ -389,8 +389,7 @@ class AssertionError extends Error {
             other = `${other.slice(0, 509)}...`;
           }
           if (operator === 'deepEqual') {
-            const eq = operator === 'deepEqual' ? 'deep-equal' : 'equal';
-            res = `${knownOperators}\n\n${res}\n\nshould loosely ${eq}\n\n`;
+            res = `${knownOperator}\n\n${res}\n\nshould loosely deep-equal\n\n`;
           } else {
             const newOperator = kReadableOperator[`${operator}Unequal`];
             if (newOperator) {