watch: clarify that the fileName parameter can be null

Add a comment to clarify that the `fileName` parameter can be `null` if the file name cannot be determined. PR-URL: #51305 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
nodejs · Mar 25, 2024 · 5183e3a · 5183e3a
1 parent 3badc11
commit 5183e3a
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/lib/internal/watch_mode/files_watcher.js b/lib/internal/watch_mode/files_watcher.js
@@ -97,8 +97,11 @@ class FilesWatcher extends EventEmitter {
       return;
     }
     const watcher = watch(path, { recursive, signal: this.#signal });
-    watcher.on('change', (eventType, fileName) => this
-      .#onChange(recursive ? resolve(path, fileName ?? '') : path));
+    watcher.on('change', (eventType, fileName) => {
+      // `fileName` can be `null` if it cannot be determined. See
+      // https://github.com/nodejs/node/pull/49891#issuecomment-1744673430.
+      this.#onChange(recursive ? resolve(path, fileName ?? '') : path);
+    });
     this.#watchers.set(path, { handle: watcher, recursive });
     if (recursive) {
       this.#removeWatchedChildren(path);