From 4f282f52f08ff3dbf71baa10a0b8e20cf98df0fa Mon Sep 17 00:00:00 2001 From: Myles Borins Date: Wed, 20 Nov 2019 12:32:59 -0500 Subject: [PATCH] deps: patch V8 to 7.9.317.23 Refs: https://github.com/v8/v8/compare/7.9.317.20...7.9.317.23 PR-URL: https://github.com/nodejs/node/pull/30560 Reviewed-By: Anna Henningsen Reviewed-By: Colin Ihrig Reviewed-By: Jiawen Geng --- deps/v8/include/v8-version.h | 2 +- deps/v8/src/objects/backing-store.cc | 10 ++++++++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/deps/v8/include/v8-version.h b/deps/v8/include/v8-version.h index 55d44e4bafab67..8970c573efda6f 100644 --- a/deps/v8/include/v8-version.h +++ b/deps/v8/include/v8-version.h @@ -11,7 +11,7 @@ #define V8_MAJOR_VERSION 7 #define V8_MINOR_VERSION 9 #define V8_BUILD_NUMBER 317 -#define V8_PATCH_LEVEL 22 +#define V8_PATCH_LEVEL 23 // Use 1 for candidates and 0 otherwise. // (Boolean macro values are not supported by all preprocessors.) diff --git a/deps/v8/src/objects/backing-store.cc b/deps/v8/src/objects/backing-store.cc index 7f6d2251a78a70..cc6741765e1962 100644 --- a/deps/v8/src/objects/backing-store.cc +++ b/deps/v8/src/objects/backing-store.cc @@ -605,8 +605,14 @@ std::shared_ptr GlobalBackingStoreRegistry::Lookup( return std::shared_ptr(); } auto backing_store = result->second.lock(); - DCHECK_EQ(buffer_start, backing_store->buffer_start()); - DCHECK_EQ(length, backing_store->byte_length()); + CHECK_EQ(buffer_start, backing_store->buffer_start()); + if (backing_store->is_wasm_memory()) { + // Grow calls to shared WebAssembly threads can be triggered from different + // workers, length equality cannot be guaranteed here. + CHECK_LE(length, backing_store->byte_length()); + } else { + CHECK_EQ(length, backing_store->byte_length()); + } return backing_store; }