-
Notifications
You must be signed in to change notification settings - Fork 29.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
doc,test: fs - reserved characters under win32
Explain the behavior of `fs.open()` under win32 that file path contains some characters and add some test cases for them. < (less than) > (greater than) : (colon) " (double quote) / (forward slash) \ (backslash) | (vertical bar or pipe) ? (question mark) * (asterisk) PR-URL: #13875 Refs: #13868 Refs: https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx Refs: https://msdn.microsoft.com/en-us/library/windows/desktop/bb540537.aspx Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
- Loading branch information
Showing
2 changed files
with
55 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
'use strict'; | ||
|
||
const common = require('../common'); | ||
const assert = require('assert'); | ||
const fs = require('fs'); | ||
const path = require('path'); | ||
|
||
if (!common.isWindows) | ||
common.skip('This test is for Windows only.'); | ||
|
||
common.refreshTmpDir(); | ||
|
||
const DATA_VALUE = 'hello'; | ||
|
||
// Refs: https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx | ||
// Ignore '/', '\\' and ':' | ||
const RESERVED_CHARACTERS = '<>"|?*'; | ||
|
||
[...RESERVED_CHARACTERS].forEach((ch) => { | ||
const pathname = path.join(common.tmpDir, `somefile_${ch}`); | ||
assert.throws( | ||
() => { | ||
fs.writeFileSync(pathname, DATA_VALUE); | ||
}, | ||
/^Error: ENOENT: no such file or directory, open '.*'$/, | ||
`failed with '${ch}'`); | ||
}); | ||
|
||
// Test for ':' (NTFS data streams). | ||
// Refs: https://msdn.microsoft.com/en-us/library/windows/desktop/bb540537.aspx | ||
const pathname = path.join(common.tmpDir, 'foo:bar'); | ||
fs.writeFileSync(pathname, DATA_VALUE); | ||
|
||
let content = ''; | ||
const fileDataStream = fs.createReadStream(pathname, { | ||
encoding: 'utf8' | ||
}); | ||
|
||
fileDataStream.on('data', (data) => { | ||
content += data; | ||
}); | ||
|
||
fileDataStream.on('end', common.mustCall(() => { | ||
assert.strictEqual(content, DATA_VALUE); | ||
})); |