process: keep process prototype in inheritance chain

The global `process` object had its prototype replaced with a fresh object that had `EventEmitter.prototype` as its prototype. With this change, the original `process.constructor.prototype` is modified to have `EventEmitter.prototype` as its prototype, reflecting that `process` objects are also `EventEmitter`s. Fixes: #14699 PR-URL: #14715 Reviewed-By: Anna Henningsen <[email protected]>
nodejs · Sep 10, 2017 · 4d2aa16 · 4d2aa16
1 parent 7f02c36
commit 4d2aa16
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/lib/internal/bootstrap_node.js b/lib/internal/bootstrap_node.js
@@ -14,9 +14,7 @@
     process._eventsCount = 0;
 
     const origProcProto = Object.getPrototypeOf(process);
-    Object.setPrototypeOf(process, Object.create(EventEmitter.prototype, {
-      constructor: Object.getOwnPropertyDescriptor(origProcProto, 'constructor')
-    }));
+    Object.setPrototypeOf(origProcProto, EventEmitter.prototype);
 
     EventEmitter.call(process);
 

diff --git a/test/parallel/test-process-prototype.js b/test/parallel/test-process-prototype.js
@@ -5,6 +5,7 @@ const EventEmitter = require('events');
 
 const proto = Object.getPrototypeOf(process);
 
+assert(process instanceof process.constructor);
 assert(proto instanceof EventEmitter);
 
 const desc = Object.getOwnPropertyDescriptor(proto, 'constructor');