Skip to content

Commit 47d59e7

Browse files
Sebastian PlesciucMylesBorins
Sebastian Plesciuc
authored andcommitted
test: fix sequential test-net-connect-local-error
Fixed sequential test-net-connect-local-error by swapping port and localPort in net.connect options. PR-URL: #13064 Fixes: #13055 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
1 parent 1d35965 commit 47d59e7

File tree

1 file changed

+9
-14
lines changed

1 file changed

+9
-14
lines changed

Diff for: test/sequential/test-net-connect-local-error.js

+9-14
Original file line numberDiff line numberDiff line change
@@ -3,28 +3,23 @@ const common = require('../common');
33
const assert = require('assert');
44
const net = require('net');
55

6+
// EADDRINUSE is expected to occur on FreeBSD
7+
// Ref: https://github.com/nodejs/node/issues/13055
8+
const expectedErrorCodes = ['ECONNREFUSED', 'EADDRINUSE'];
69
const client = net.connect({
7-
port: common.PORT + 1,
8-
localPort: common.PORT,
10+
port: common.PORT,
11+
localPort: common.PORT + 1,
912
localAddress: common.localhostIPv4
1013
});
1114

1215
client.on('error', common.mustCall(function onError(err) {
16+
assert.ok(expectedErrorCodes.includes(err.code));
1317
assert.strictEqual(err.syscall, 'connect');
14-
assert.strictEqual(err.code, 'ECONNREFUSED');
15-
assert.strictEqual(
16-
err.localPort,
17-
common.PORT,
18-
`${err.localPort} !== ${common.PORT} in ${err}`
19-
);
20-
assert.strictEqual(
21-
err.localAddress,
22-
common.localhostIPv4,
23-
`${err.localAddress} !== ${common.localhostIPv4} in ${err}`
24-
);
18+
assert.strictEqual(err.localPort, common.PORT + 1);
19+
assert.strictEqual(err.localAddress, common.localhostIPv4);
2520
assert.strictEqual(
2621
err.message,
27-
`connect ECONNREFUSED ${err.address}:${err.port} ` +
22+
`connect ${err.code} ${err.address}:${err.port} ` +
2823
`- Local (${err.localAddress}:${err.localPort})`
2924
);
3025
}));

0 commit comments

Comments
 (0)