Skip to content

Commit

Permalink
deps: V8: cherry-pick a7dffcd767be
Browse files Browse the repository at this point in the history
Original commit message:

    [postmortem] Load files using utf-8 to support Python 3

    Change-Id: I174d38cc33210c07d1a7596627e1b2d21bb06313
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1895560
    Reviewed-by: Mathias Bynens <[email protected]>
    Commit-Queue: Michaël Zasso <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#64717}

Refs: v8/v8@a7dffcd

PR-URL: #30218
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
  • Loading branch information
cclauss authored and targos committed Nov 5, 2019
1 parent 68e4b5a commit 46c9194
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.18',
'v8_embedder_string': '-node.19',

##### V8 defaults for Node.js #####

Expand Down
5 changes: 3 additions & 2 deletions deps/v8/tools/gen-postmortem-metadata.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
# for py2/py3 compatibility
from __future__ import print_function

import io
import re
import sys

Expand Down Expand Up @@ -382,7 +383,7 @@ def load_objects():


def load_objects_from_file(objfilename, checktypes):
objfile = open(objfilename, 'r');
objfile = io.open(objfilename, 'r', encoding='utf-8');
in_insttype = False;

typestr = '';
Expand Down Expand Up @@ -577,7 +578,7 @@ def load_fields():


def load_fields_from_file(filename):
inlfile = open(filename, 'r');
inlfile = io.open(filename, 'r', encoding='utf-8');

#
# Each class's fields and the corresponding offsets are described in the
Expand Down

0 comments on commit 46c9194

Please sign in to comment.