src: fix -Wsign-compare warnings

This commit addresses the following compilation warnings: ../src/node_crypto.cc:5053:3: warning: comparison of integers of different signs: 'unsigned int' and 'int' [-Wsign-compare] CHECK_EQ(n, BN_bn2binpad(r, data, n)); ../src/node_crypto.cc:5054:3: warning: comparison of integers of different signs: 'unsigned int' and 'int' [-Wsign-compare] CHECK_EQ(n, BN_bn2binpad(s, data + n, n)); PR-URL: #30565 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: David Carlier <[email protected]>
nodejs · Nov 30, 2019 · 44f28ea · 44f28ea
1 parent 8256d38
commit 44f28ea
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/node_crypto.cc b/src/node_crypto.cc
@@ -5050,8 +5050,8 @@ static AllocatedBuffer ConvertSignatureToP1363(Environment* env,
 
   const BIGNUM* r = ECDSA_SIG_get0_r(asn1_sig);
   const BIGNUM* s = ECDSA_SIG_get0_s(asn1_sig);
-  CHECK_EQ(n, BN_bn2binpad(r, data, n));
-  CHECK_EQ(n, BN_bn2binpad(s, data + n, n));
+  CHECK_EQ(n, static_cast<unsigned int>(BN_bn2binpad(r, data, n)));
+  CHECK_EQ(n, static_cast<unsigned int>(BN_bn2binpad(s, data + n, n)));
 
   ECDSA_SIG_free(asn1_sig);