report: add queue info for udp

nodejs · Aug 22, 2022 · 3bc2c6f · 3bc2c6f
1 parent 937520a
commit 3bc2c6f
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/src/node_report_utils.cc b/src/node_report_utils.cc
@@ -261,7 +261,14 @@ void WalkHandle(uv_handle_t* h, void* arg) {
     writer->json_keyvalue("writable",
                           static_cast<bool>(uv_is_writable(&handle->stream)));
   }
-
+  if (h->type == UV_UDP) {
+    writer->json_keyvalue(
+        "writeQueueSize",
+        uv_udp_get_send_queue_size(reinterpret_cast<uv_udp_t*>(h)));
+    writer->json_keyvalue(
+        "writeQueueCount",
+        uv_udp_get_send_queue_count(reinterpret_cast<uv_udp_t*>(h)));
+  }
   writer->json_end();
 }
 

diff --git a/test/report/test-report-fields.js b/test/report/test-report-fields.js
@@ -0,0 +1,15 @@
+'use strict';
+require('../common');
+const assert = require('assert');
+const helper = require('../common/report');
+const dgram = require('dgram');
+{
+  const socket = dgram.createSocket('udp4');
+  const report = process.report.getReport();
+  helper.validateContent(report);
+  const udp = report.libuv.filter((item) => item.type === 'udp');
+  assert.strictEqual(udp.length > 0, true);
+  assert.strictEqual(udp[0].writeQueueSize, 0);
+  assert.strictEqual(udp[0].writeQueueCount, 0);
+  socket.close();
+}