Skip to content

Commit 3936842

Browse files
committed
build: disable PCH when built with Clang on Windows
1 parent 6cf955a commit 3936842

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

node.gypi

+9-5
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,15 @@
6565
'NODE_PLATFORM="win32"',
6666
'_UNICODE=1',
6767
],
68-
'msvs_precompiled_header': 'tools/msvs/pch/node_pch.h',
69-
'msvs_precompiled_source': 'tools/msvs/pch/node_pch.cc',
70-
'sources': [
71-
'<(_msvs_precompiled_header)',
72-
'<(_msvs_precompiled_source)',
68+
'conditions': [
69+
['clang==0', {
70+
'msvs_precompiled_header': 'tools/msvs/pch/node_pch.h',
71+
'msvs_precompiled_source': 'tools/msvs/pch/node_pch.cc',
72+
'sources': [
73+
'<(_msvs_precompiled_header)',
74+
'<(_msvs_precompiled_source)',
75+
],
76+
}],
7377
],
7478
}, { # POSIX
7579
'defines': [ '__POSIX__' ],

tools/v8_gypfiles/v8.gyp

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
'type': 'none',
4949
'toolsets': ['host', 'target'],
5050
'conditions': [
51-
['OS=="win"', {
51+
['OS=="win" and clang==0', {
5252
'direct_dependent_settings': {
5353
'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h',
5454
'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc',

0 commit comments

Comments
 (0)