src: always signal V8 for intercepted properties

Closes: #42962

PR-URL: #42963
Fixes: #42962
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>

src/node_contextify.cc

@@ -449,16 +449,8 @@ void ContextifyContext::PropertySetterCallback(
       !is_function)
     return;
 
-  if (!is_declared_on_global_proxy && is_declared_on_sandbox  &&
-      args.ShouldThrowOnError() && is_contextual_store && !is_function) {
-    // The property exists on the sandbox but not on the global
-    // proxy. Setting it would throw because we are in strict mode.
-    // Don't attempt to set it by signaling that the call was
-    // intercepted. Only change the value on the sandbox.
-    args.GetReturnValue().Set(false);
-  }
-
   USE(ctx->sandbox()->Set(context, property, value));
+  args.GetReturnValue().Set(value);
 }
 
 // static

test/parallel/test-vm-global-setter.js

@@ -0,0 +1,32 @@
+'use strict';
+const common = require('../common');
+const assert = require('assert');
+const vm = require('vm');
+
+const window = createWindow();
+
+const descriptor =
+  Object.getOwnPropertyDescriptor(window.globalProxy, 'onhashchange');
+
+assert.strictEqual(typeof descriptor.get, 'function');
+assert.strictEqual(typeof descriptor.set, 'function');
+assert.strictEqual(descriptor.configurable, true);
+
+// Regression test for GH-42962. This assignment should not throw.
+window.globalProxy.onhashchange = () => {};
+
+assert.strictEqual(window.globalProxy.onhashchange, 42);
+
+function createWindow() {
+  const obj = {};
+  vm.createContext(obj);
+  Object.defineProperty(obj, 'onhashchange', {
+    get: common.mustCall(() => 42),
+    set: common.mustCall(),
+    configurable: true
+  });
+
+  obj.globalProxy = vm.runInContext('this', obj);
+
+  return obj;
+}