File tree Expand file tree Collapse file tree 2 files changed +7
-2
lines changed Expand file tree Collapse file tree 2 files changed +7
-2
lines changed Original file line number Diff line number Diff line change 3636
3737 # Reset this number to 0 on major V8 upgrades.
3838 # Increment by one for each non-official patch applied to deps/v8.
39- 'v8_embedder_string' : '-node.15 ' ,
39+ 'v8_embedder_string' : '-node.16 ' ,
4040
4141 ##### V8 defaults for Node.js #####
4242
Original file line number Diff line number Diff line change @@ -173,14 +173,19 @@ namespace base {
173173// base::is_trivially_copyable will differ for these cases.
174174template <typename T>
175175struct is_trivially_copyable {
176- #if V8_CC_MSVC
176+ #if V8_CC_MSVC || (__GNUC__ == 12 && __GNUC_MINOR__ < 2)
177177 // Unfortunately, MSVC 2015 is broken in that std::is_trivially_copyable can
178178 // be false even though it should be true according to the standard.
179179 // (status at 2018-02-26, observed on the msvc waterfall bot).
180180 // Interestingly, the lower-level primitives used below are working as
181181 // intended, so we reimplement this according to the standard.
182182 // See also https://developercommunity.visualstudio.com/content/problem/
183183 // 170883/msvc-type-traits-stdis-trivial-is-bugged.html.
184+ //
185+ // GCC 12.1 and 12.2 are broken too, they are shipped by some stable Linux
186+ // distributions, so the same polyfill is also used.
187+ // See
188+ // https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=aeba3e009b0abfccaf01797556445dbf891cc8dc
184189 static constexpr bool value =
185190 // Copy constructor is trivial or deleted.
186191 (std::is_trivially_copy_constructible<T>::value ||
You can’t perform that action at this time.
0 commit comments