build,deps: add NOMINMAX to V8 Windows builds

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/1456620 PR-URL: #25852 Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]>
nodejs · Mar 14, 2019 · 3531fe9 · 3531fe9
1 parent 1c494b0
commit 3531fe9
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/deps/v8/gypfiles/toolchain.gypi b/deps/v8/gypfiles/toolchain.gypi
@@ -996,6 +996,7 @@
       ['OS=="win"', {
         'defines': [
           'WIN32',
+          'NOMINMAX',  # Refs: https://chromium-review.googlesource.com/c/v8/v8/+/1456620
         ],
         # 4351: VS 2005 and later are warning us that they've fixed a bug
         #       present in VS 2003 and earlier.