fs: validate fd from cpp on close

PR-URL: #52051 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
nodejs · May 3, 2024 · 33ad86c · 33ad86c
1 parent 34667c0
commit 33ad86c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/lib/fs.js b/lib/fs.js
@@ -518,7 +518,7 @@ function close(fd, callback = defaultCloseCallback) {
 
   const req = new FSReqCallback();
   req.oncomplete = callback;
-  binding.close(getValidatedFd(fd), req);
+  binding.close(fd, req);
 }
 
 /**
@@ -527,7 +527,7 @@ function close(fd, callback = defaultCloseCallback) {
  * @returns {void}
  */
 function closeSync(fd) {
-  binding.close(getValidatedFd(fd));
+  binding.close(fd);
 }
 
 /**

diff --git a/src/node_file.cc b/src/node_file.cc
@@ -984,8 +984,10 @@ void Close(const FunctionCallbackInfo<Value>& args) {
   const int argc = args.Length();
   CHECK_GE(argc, 1);
 
-  CHECK(args[0]->IsInt32());
-  int fd = args[0].As<Int32>()->Value();
+  int fd;
+  if (!GetValidatedFd(env, args[0]).To(&fd)) {
+    return;
+  }
   env->RemoveUnmanagedFd(fd);
 
   if (argc > 1) {  // close(fd, req)