test_runner: don't exceed call stack when filtering

This commit updates filteredRun() to call postRun() after a microtask instead of synchronously. Currently, if approximately 1,545 subtests are filtered, enough synchronous calls can be made to cause a call stack exceeded exception. PR-URL: #52488 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
nodejs · Apr 29, 2024 · 3287553 · 3287553
1 parent b4ccb6c
commit 3287553
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/lib/internal/test_runner/test.js b/lib/internal/test_runner/test.js
@@ -29,6 +29,7 @@ const {
 } = primordials;
 const { getCallerLocation } = internalBinding('util');
 const { addAbortListener } = require('internal/events/abort_listener');
+const { queueMicrotask } = require('internal/process/task_queues');
 const { AsyncResource } = require('async_hooks');
 const { AbortController } = require('internal/abort_controller');
 const {
@@ -673,7 +674,7 @@ class Test extends AsyncResource {
     this.pass();
     this.subtests = [];
     this.report = noop;
-    this.postRun();
+    queueMicrotask(() => this.postRun());
   }
 
   async run() {