Skip to content

Commit

Permalink
benchmark: remove problematic tls params
Browse files Browse the repository at this point in the history
These very small values can cause crashes/exceptions to occur on some
systems because most time is spent in V8 GC or in parts of node core
that are not being tested (e.g. streams).

PR-URL: #31816
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
mscdex authored and MylesBorins committed Mar 9, 2020
1 parent c0ba6ec commit 31ec443
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion benchmark/tls/secure-pair.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const common = require('../common.js');
const bench = common.createBenchmark(main, {
dur: [5],
securing: ['SecurePair', 'TLSSocket', 'clear'],
size: [2, 100, 1024, 1024 * 1024]
size: [100, 1024, 1024 * 1024]
});

const fixtures = require('../../test/common/fixtures');
Expand Down
2 changes: 1 addition & 1 deletion benchmark/tls/throughput.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const common = require('../common.js');
const bench = common.createBenchmark(main, {
dur: [5],
type: ['buf', 'asc', 'utf'],
size: [2, 1024, 1024 * 1024, 4 * 1024 * 1024, 16 * 1024 * 1024]
size: [100, 1024, 1024 * 1024, 4 * 1024 * 1024, 16 * 1024 * 1024]
});

const fixtures = require('../../test/common/fixtures');
Expand Down
4 changes: 2 additions & 2 deletions test/benchmark/test-benchmark-tls.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ runBenchmark('tls',
'concurrency=1',
'dur=0.1',
'n=1',
'size=2',
'size=1024',
'securing=SecurePair',
'type=asc'
'type=buf'
],
{
NODEJS_BENCHMARK_ZERO_ALLOWED: 1,
Expand Down

0 comments on commit 31ec443

Please sign in to comment.