tools: check for git tag before promoting release

PR-URL: #24670 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Dec 5, 2018 · 2ef6aed · 2ef6aed
1 parent 193f315
commit 2ef6aed
Showing 1 changed file with 12 additions and 6 deletions.
diff --git a/tools/release.sh b/tools/release.sh
@@ -81,6 +81,14 @@ fi
 echo "Using GPG key: $gpgkey"
 echo "  Fingerprint: $gpgfing"
 
+function checktag {
+  local version=$1
+
+  if ! git tag -v $version 2>&1 | grep "${gpgkey}" | grep key > /dev/null; then
+    echo "Could not find signed tag for \"${version}\" or GPG key is not yours"
+    exit 1
+  fi
+}
 
 ################################################################################
 ## Create and sign checksums file for a given version
@@ -90,11 +98,6 @@ function sign {
 
   local version=$1
 
-  if ! git tag -v $version 2>&1 | grep "${gpgkey}" | grep key > /dev/null; then
-    echo "Could not find signed tag for \"${version}\" or GPG key is not yours"
-    exit 1
-  fi
-
   ghtaggedversion=$(curl -sL https://raw.githubusercontent.com/nodejs/node/${version}/src/node_version.h \
       | awk '/define NODE_(MAJOR|MINOR|PATCH)_VERSION/{ v = v "." $3 } END{ v = "v" substr(v, 2); print v }')
   if [ "${version}" != "${ghtaggedversion}" ]; then
@@ -150,7 +153,8 @@ function sign {
 
 
 if [ -n "${signversion}" ]; then
-    sign ${signversion}
+		checktag $signversion
+    sign $signversion
     exit 0
 fi
 
@@ -192,6 +196,8 @@ for version in $versions; do
       continue
     fi
 
+		checktag $version
+
     echo -e "\n# Promoting ${version}..."
 
     ssh ${customsshkey} ${webuser}@${webhost} $promotecmd nodejs $version