worker: add missing return value in case of fatal exceptions

This adds a missing return value for the worker specific fatal exception handler. PR-URL: #29036 Reviewed-By: Beth Griggs <[email protected]>
nodejs · Oct 15, 2019 · 2eae030 · 2eae030
1 parent b43d7e8
commit 2eae030
Showing 1 changed file with 18 additions and 16 deletions.
diff --git a/lib/internal/worker.js b/lib/internal/worker.js
@@ -489,23 +489,25 @@ function setupChild(evalScript) {
     }
     debug(`[${threadId}] fatal exception caught = ${caught}`);
 
-    if (!caught) {
-      let serialized;
-      try {
-        serialized = serializeError(error);
-      } catch {}
-      debug(`[${threadId}] fatal exception serialized = ${!!serialized}`);
-      if (serialized)
-        port.postMessage({
-          type: messageTypes.ERROR_MESSAGE,
-          error: serialized
-        });
-      else
-        port.postMessage({ type: messageTypes.COULD_NOT_SERIALIZE_ERROR });
-      clearAsyncIdStack();
-
-      process.exit();
+    if (caught) {
+      return true;
     }
+
+    let serialized;
+    try {
+      serialized = serializeError(error);
+    } catch {}
+    debug(`[${threadId}] fatal exception serialized = ${!!serialized}`);
+    if (serialized)
+      port.postMessage({
+        type: messageTypes.ERROR_MESSAGE,
+        error: serialized
+      });
+    else
+      port.postMessage({ type: messageTypes.COULD_NOT_SERIALIZE_ERROR });
+    clearAsyncIdStack();
+
+    process.exit();
   }
 }