From 2dc52ad09cba38069979c802f1adf1943e6d5afe Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Mon, 9 Sep 2019 23:54:59 +0200 Subject: [PATCH] stream: simplify isUint8Array helper The fallback code is no longer used when exporting to readable-stream. Refs: https://github.com/nodejs/node/pull/29475 PR-URL: https://github.com/nodejs/node/pull/29514 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Trivikram Kamat Reviewed-By: Matteo Collina Reviewed-By: David Carlier Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca Reviewed-By: James M Snell Reviewed-By: Jiawen Geng --- lib/stream.js | 24 +----------------------- 1 file changed, 1 insertion(+), 23 deletions(-) diff --git a/lib/stream.js b/lib/stream.js index 4918434167c535..826f0e6d9adb6c 100644 --- a/lib/stream.js +++ b/lib/stream.js @@ -21,8 +21,6 @@ 'use strict'; -const { Object } = primordials; - const { Buffer } = require('buffer'); const pipeline = require('internal/streams/pipeline'); const eos = require('internal/streams/end-of-stream'); @@ -43,27 +41,7 @@ Stream.finished = eos; // Backwards-compat with node 0.4.x Stream.Stream = Stream; -// Internal utilities -try { - const types = require('internal/util/types'); - if (types && typeof types.isUint8Array === 'function') { - Stream._isUint8Array = types.isUint8Array; - } else { - // This throws for Node < 4.2.0 because there's no util binding and - // returns undefined for Node < 7.4.0. - // Please do not convert process.binding() to internalBinding() here. - // This is for compatibility with older versions when loaded as - // readable-stream. - Stream._isUint8Array = process.binding('util').isUint8Array; - } -} catch (e) { // eslint-disable-line no-unused-vars -} - -if (!Stream._isUint8Array) { - Stream._isUint8Array = function _isUint8Array(obj) { - return Object.prototype.toString.call(obj) === '[object Uint8Array]'; - }; -} +Stream._isUint8Array = require('internal/util/types').isUint8Array; const version = process.version.substr(1).split('.'); if (version[0] === 0 && version[1] < 12) {