From 2ae2a964a0f5fdfda1cae95fcdd97303814cb70d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Thu, 13 Jul 2017 16:02:37 +0200 Subject: [PATCH] build: run test-hash-seed at the end of test-v8 The v8 and test-hash-seed targets cannot be run in parallel because they need different copies of the deps/v8 directory. Ref: https://github.com/nodejs/node/pull/14004#issuecomment-314774773 Backport-PR-URL: https://github.com/nodejs/node/pull/15562 PR-URL: https://github.com/nodejs/node/pull/14219 Reviewed-By: Michael Dawson Reviewed-By: Refael Ackermann Reviewed-By: Anna Henningsen --- Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index cd78155b9a62df..5b67f92076bb09 100644 --- a/Makefile +++ b/Makefile @@ -259,13 +259,15 @@ test-timers: test-timers-clean: $(MAKE) --directory=tools clean -test-v8: v8 test-hash-seed +test-v8: v8 # note: performs full test unless QUICKCHECK is specified deps/v8/tools/run-tests.py --arch=$(V8_ARCH) \ --mode=$(BUILDTYPE_LOWER) $(V8_TEST_NO_I18N) $(QUICKCHECK_ARG) \ --no-presubmit \ --shell-dir=$(PWD)/deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) \ $(TAP_V8) + @echo Testing hash seed + $(MAKE) test-hash-seed test-v8-intl: v8 # note: performs full test unless QUICKCHECK is specified