Skip to content

Commit

Permalink
test: convert new tests to use error types
Browse files Browse the repository at this point in the history
Backport-PR-URL: #19265
PR-URL: #18581
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
  • Loading branch information
jackhorton authored and MylesBorins committed May 1, 2018
1 parent 5c0983e commit 2838f9b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/addons-napi/test_typedarray/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ arrayTypes.forEach((currentType) => {
const template = Reflect.construct(currentType, buffer);
assert.throws(() => {
test_typedarray.CreateTypedArray(template, buffer, 0, 136);
}, /Invalid typed array length/);
}, RangeError);
});

const nonByteArrayTypes = [ Int16Array, Uint16Array, Int32Array, Uint32Array,
Expand All @@ -71,5 +71,5 @@ nonByteArrayTypes.forEach((currentType) => {
test_typedarray.CreateTypedArray(template, buffer,
currentType.BYTES_PER_ELEMENT + 1, 1);
console.log(`start of offset ${currentType}`);
}, /start offset of/);
}, RangeError);
});

0 comments on commit 2838f9b

Please sign in to comment.