diff --git a/src/node_buffer.cc b/src/node_buffer.cc index 7d428b2b134b51..f2c075f8ab1c95 100644 --- a/src/node_buffer.cc +++ b/src/node_buffer.cc @@ -472,10 +472,11 @@ void StringSlice(const FunctionCallbackInfo& args) { // need to reorder on BE platforms. See http://nodejs.org/api/buffer.html // regarding Node's "ucs2" encoding specification. const bool aligned = (reinterpret_cast(data) % sizeof(*buf) == 0); - if (IsLittleEndian() && aligned) { - buf = reinterpret_cast(data); - } else { + if (IsLittleEndian() && !aligned) { // Make a copy to avoid unaligned accesses in v8::String::NewFromTwoByte(). + // This applies ONLY to little endian platforms, as misalignment will be + // handled by a byte-swapping operation in StringBytes::Encode on + // big endian platforms. uint16_t* copy = new uint16_t[length]; for (size_t i = 0, k = 0; i < length; i += 1, k += 2) { // Assumes that the input is little endian. @@ -485,6 +486,8 @@ void StringSlice(const FunctionCallbackInfo& args) { } buf = copy; release = true; + } else { + buf = reinterpret_cast(data); } args.GetReturnValue().Set(StringBytes::Encode(env->isolate(), buf, length)); diff --git a/src/string_bytes.cc b/src/string_bytes.cc index 90fafd40cd3379..a916caf75e8960 100644 --- a/src/string_bytes.cc +++ b/src/string_bytes.cc @@ -6,6 +6,7 @@ #include #include // memcpy +#include // When creating strings >= this length v8's gc spins up and consumes // most of the execution time. For these cases it's more performant to @@ -406,9 +407,7 @@ size_t StringBytes::Write(Isolate* isolate, reinterpret_cast(buf) % sizeof(uint16_t); if (is_aligned) { uint16_t* const dst = reinterpret_cast(buf); - for (size_t i = 0; i < nchars; i++) - dst[i] = dst[i] << 8 | dst[i] >> 8; - break; + SwapBytes(dst, dst, nchars); } ASSERT_EQ(sizeof(uint16_t), 2); @@ -857,7 +856,16 @@ Local StringBytes::Encode(Isolate* isolate, const uint16_t* buf, size_t buflen) { Local val; - + std::vector dst; + if (IsBigEndian()) { + // Node's "ucs2" encoding expects LE character data inside a + // Buffer, so we need to reorder on BE platforms. See + // http://nodejs.org/api/buffer.html regarding Node's "ucs2" + // encoding specification + dst.resize(buflen); + SwapBytes(&dst[0], buf, buflen); + buf = &dst[0]; + } if (buflen < EXTERN_APEX) { val = String::NewFromTwoByte(isolate, buf, diff --git a/src/util-inl.h b/src/util-inl.h index 75bdb4784aaaf3..669b7e7535884b 100644 --- a/src/util-inl.h +++ b/src/util-inl.h @@ -198,6 +198,20 @@ TypeName* Unwrap(v8::Local object) { return static_cast(pointer); } +void SwapBytes(uint16_t* dst, const uint16_t* src, size_t buflen) { + for (size_t i = 0; i < buflen; i++) { + // __builtin_bswap16 generates more efficient code with + // g++ 4.8 on PowerPC and other big-endian archs +#ifdef __GNUC__ + dst[i] = __builtin_bswap16(src[i]); +#else + dst[i] = (src[i] << 8) | (src[i] >> 8); +#endif + } +} + + + } // namespace node #endif // SRC_UTIL_INL_H_ diff --git a/src/util.h b/src/util.h index 20cd54758cb102..7b2bc0f1a270ba 100644 --- a/src/util.h +++ b/src/util.h @@ -176,6 +176,8 @@ inline void ClearWrap(v8::Local object); template inline TypeName* Unwrap(v8::Local object); +inline void SwapBytes(uint16_t* dst, const uint16_t* src, size_t buflen); + class Utf8Value { public: explicit Utf8Value(v8::Isolate* isolate, v8::Local value);