Skip to content

Commit

Permalink
doc: clarify release process for new releasers
Browse files Browse the repository at this point in the history
PR-URL: #43739
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
  • Loading branch information
RafaelGSS authored and danielleadams committed Jul 26, 2022
1 parent 6f1d2df commit 2815bd3
Showing 1 changed file with 16 additions and 1 deletion.
17 changes: 16 additions & 1 deletion doc/contributing/releases.md
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,20 @@ failed build if you start again!
Jenkins collects the artifacts from the builds, allowing you to download and
install the new build. Make sure that the build appears correct. Check the
version numbers, and perform some basic checks to confirm that all is well with
the build before moving forward.
the build before moving forward. Use the following list as a baseline:

* `process.version` is as expected
* `process.release` is as expected
* `process.versions` is as expected (for example, `openssl` or `llhttp` version
must be in the expected updated version)
* npm version (check it matches what we expect)
* Run the test suite against the built binaries (optional)

```console
./tools/test.py --shell ~/Downloads/node-v18.5.0-linux-x64/bin/node
```

<sup>There may be test issues if the branch used to test does not match the Node.js binary.</sup>

### 11. Tag and sign the release commit

Expand Down Expand Up @@ -510,6 +523,8 @@ include the release code name.
The tag **must** be signed using the GPG key that's listed for you on the
project README.

**Note**: Don't push the tag to remote at this point.

### 12. Set up for the next release

On release proposal branch, edit `src/node_version.h` again and:
Expand Down

0 comments on commit 2815bd3

Please sign in to comment.