test: refactored test-http-response-splitting to use countdown

PR-URL: #17348 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
nodejs · Dec 20, 2017 · 279d844 · 279d844
1 parent a3d218d
commit 279d844
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/test/parallel/test-http-response-splitting.js b/test/parallel/test-http-response-splitting.js
@@ -5,6 +5,7 @@ const http = require('http');
 const net = require('net');
 const url = require('url');
 const assert = require('assert');
+const Countdown = require('../common/countdown');
 
 // Response splitting example, credit: Amit Klein, Safebreach
 const str = '/welcome?lang=bar%c4%8d%c4%8aContentLength:%200%c4%8d%c4%8a%c' +
@@ -18,6 +19,7 @@ const x = 'fooഊSet-Cookie: foo=barഊഊ<script>alert("Hi!")</script>';
 const y = 'foo⠊Set-Cookie: foo=bar';
 
 let count = 0;
+const countdown = new Countdown(3, () => server.close());
 
 function test(res, code, header) {
   assert.throws(() => {
@@ -40,8 +42,7 @@ const server = http.createServer((req, res) => {
     default:
       assert.fail('should not get to here.');
   }
-  if (count === 3)
-    server.close();
+  countdown.dec();
   res.end('ok');
 });
 server.listen(0, () => {