From 2655c7b194f3e265bf0172db39edde886d8e8af0 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Wed, 6 Jun 2018 13:24:00 -0700 Subject: [PATCH] test: mark fs-readfile-tostring-fail flaky for all test-fs-readfile-tostring-fail is unreliable until a libuv fix lands. It had previously been marked flaky on macOS, but it has been observed to also fail on AIX. Mark it flaky everywhere. Refs: https://github.com/libuv/libuv/pull/1742 PR-URL: https://github.com/nodejs/node/pull/21177 Reviewed-By: Matheus Marchini Reviewed-By: Gireesh Punathil Reviewed-By: Jon Moss --- test/sequential/sequential.status | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/sequential/sequential.status b/test/sequential/sequential.status index 07df25bbc754b6..85e7fb77107740 100644 --- a/test/sequential/sequential.status +++ b/test/sequential/sequential.status @@ -5,6 +5,9 @@ prefix sequential # sample-test : PASS,FLAKY [true] # This section applies to all platforms +# This test will be flaky until https://github.com/libuv/libuv/pull/1742 lands +# on Node.js. +test-fs-readfile-tostring-fail: PASS, FLAKY [$system==win32] test-inspector-async-call-stack : PASS, FLAKY @@ -15,9 +18,6 @@ test-inspector-async-hook-setup-at-signal: PASS, FLAKY [$system==linux] [$system==macos] -# This test will be flaky until https://github.com/libuv/libuv/pull/1742 lands -# on Node.js. -test-fs-readfile-tostring-fail: PASS, FLAKY [$system==solaris] # Also applies to SmartOS