-
Notifications
You must be signed in to change notification settings - Fork 29.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
deps: backport 6d38f89d from upstream V8
Original commit message: [turbofan] Boost performance of Array.prototype.shift by 4x. For small arrays, it's way faster to just move the elements instead of doing the fairly complex and heavy-weight left-trimming. Crankshaft has had this optimization for small arrays already; this CL more or less ports this functionality to TurboFan, which yields a 4x speed-up when using shift on small arrays (with up to 16 elements). This should recover some of the regressions reported in the Node.js issues #12657 and discovered for the syncthrough module using https://github.com/mcollina/syncthrough/blob/master/benchmarks/basic.js as benchmark. [email protected] BUG=v8:6376 Review-Url: https://codereview.chromium.org/2874453002 Cr-Commit-Position: refs/heads/master@{#45216} PR-URL: #13162 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]>
- Loading branch information
Showing
6 changed files
with
232 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
// Copyright 2017 the V8 project authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style license that can be | ||
// found in the LICENSE file. | ||
|
||
// Flags: --allow-natives-syntax | ||
|
||
(function() { | ||
function doShift(a) { return a.shift(); } | ||
|
||
function test() { | ||
var a = [0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16]; | ||
assertEquals(0, doShift(a)); | ||
assertEquals([1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16], a); | ||
} | ||
|
||
test(); | ||
test(); | ||
%OptimizeFunctionOnNextCall(doShift); | ||
test(); | ||
})(); | ||
|
||
(function() { | ||
function doShift(a) { return a.shift(); } | ||
|
||
function test() { | ||
var a = [0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16.1]; | ||
assertEquals(0, doShift(a)); | ||
assertEquals([1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16.1], a); | ||
} | ||
|
||
test(); | ||
test(); | ||
%OptimizeFunctionOnNextCall(doShift); | ||
test(); | ||
})(); | ||
|
||
(function() { | ||
function doShift(a) { return a.shift(); } | ||
|
||
function test() { | ||
var a = [0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,"16"]; | ||
assertEquals(0, doShift(a)); | ||
assertEquals([1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,"16"], a); | ||
} | ||
|
||
test(); | ||
test(); | ||
%OptimizeFunctionOnNextCall(doShift); | ||
test(); | ||
})(); |