process: maintain constructor descriptor

Use the original property descriptor instead of just taking the value, which would, by default, be non-writable and non-configurable. PR-URL: #9306 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
nodejs · Mar 28, 2017 · 2462fd8 · 2462fd8
1 parent 7aeeee3
commit 2462fd8
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/lib/internal/bootstrap_node.js b/lib/internal/bootstrap_node.js
@@ -13,10 +13,9 @@
     const EventEmitter = NativeModule.require('events');
     process._eventsCount = 0;
 
+    const origProcProto = Object.getPrototypeOf(process);
     Object.setPrototypeOf(process, Object.create(EventEmitter.prototype, {
-      constructor: {
-        value: process.constructor
-      }
+      constructor: Object.getOwnPropertyDescriptor(origProcProto, 'constructor')
     }));
 
     EventEmitter.call(process);

diff --git a/test/parallel/test-process-prototype.js b/test/parallel/test-process-prototype.js
@@ -0,0 +1,15 @@
+'use strict';
+require('../common');
+const assert = require('assert');
+const EventEmitter = require('events');
+
+const proto = Object.getPrototypeOf(process);
+
+assert(proto instanceof EventEmitter);
+
+const desc = Object.getOwnPropertyDescriptor(proto, 'constructor');
+
+assert.strictEqual(desc.value, process.constructor);
+assert.strictEqual(desc.writable, true);
+assert.strictEqual(desc.enumerable, false);
+assert.strictEqual(desc.configurable, true);