From 2294ba49be01590b4ee3cc0d101c541d21d958dc Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Sun, 5 Nov 2017 11:33:13 +0100 Subject: [PATCH] test: tick processor version check regression test Verify that v8-version log lines are parsed and matched correctly. Fixes: https://github.com/nodejs/node/issues/16736 PR-URL: https://github.com/nodejs/node/pull/16769 Reviewed-By: Colin Ihrig Reviewed-By: James M Snell --- .../test-tick-processor-version-check.js | 41 +++++++++++++++++++ 1 file changed, 41 insertions(+) create mode 100644 test/parallel/test-tick-processor-version-check.js diff --git a/test/parallel/test-tick-processor-version-check.js b/test/parallel/test-tick-processor-version-check.js new file mode 100644 index 00000000000000..b253adfb59b6f3 --- /dev/null +++ b/test/parallel/test-tick-processor-version-check.js @@ -0,0 +1,41 @@ +// Flags: --expose-internals +'use strict'; +require('../common'); +const assert = require('assert'); +const { versionCheck } = require('internal/v8_prof_polyfill'); + +assert.strictEqual(versionCheck('v8-version,1,2,3,4,0', '1.2.3'), undefined); +assert.strictEqual(versionCheck('v8-version,1,2,3,4,0', '1.2.3.3'), undefined); +assert.strictEqual(versionCheck('v8-version,1,2,3,4,0', '1.2.3.4'), undefined); +assert.strictEqual(versionCheck('v8-version,1,2,3,4,0', '1.2.3.5'), undefined); +assert.strictEqual(versionCheck('v8-version,1,2,3,4,-node.1,0', '1.2.3'), + undefined); +assert.strictEqual(versionCheck('v8-version,1,2,3,4,-node.1,0', '1.2.3.4'), + undefined); +assert.strictEqual(versionCheck('v8-version,1,2,3,4,-node.1,0', '1.2.3-node.1'), + undefined); +assert.strictEqual(versionCheck('v8-version,1,2,3,4,-node.1,0', '1.2.3-node.2'), + undefined); +assert.strictEqual( + versionCheck('v8-version,1,2,3,4,-node.1,0', '1.2.3.4-node.2'), + undefined); + +{ + const expected = 'Unable to read v8-version from log file.'; + assert.strictEqual(versionCheck('faux', '1.2.3'), expected); + assert.strictEqual(versionCheck('v8-version', '1.2.3'), expected); + assert.strictEqual(versionCheck('v8-version,1', '1.2.3'), expected); + assert.strictEqual(versionCheck('v8-version,1,2', '1.2.3'), expected); + assert.strictEqual(versionCheck('v8-version,1,2,3', '1.2.3'), expected); + assert.strictEqual(versionCheck('v8-version,1,2,3,4', '1.2.3'), expected); + assert.strictEqual(versionCheck('v8-version,1,2,3,4,5,6,7', '1.2.3'), + expected); +} + +{ + const expected = 'Testing v8 version different from logging version'; + assert.strictEqual(versionCheck('v8-version,4,3,2,1,0', '1.2.3'), expected); + assert.strictEqual(versionCheck('v8-version,4,3,2,1,0', '1.2.3.4'), expected); + assert.strictEqual(versionCheck('v8-version,4,3,2,1,0', '4.3.1.1'), expected); + assert.strictEqual(versionCheck('v8-version,4,3,2,1,0', '4.3.3.1'), expected); +}