Skip to content

Commit

Permalink
test: skip tests consistently in parallel.status
Browse files Browse the repository at this point in the history
Some tests are marked SKIP,FLAKY (resulting in yellow/unstable CI when
they fail) and others are marked SKIP (which means the results don't
affect CI at all). There doesn't seem to be any reason for the
difference. Mark them all as SKIP as IBM i for consistency and to have
the luxury of a green daily CI. We'll want these to be at least
SKIP,FLAKY (and preferably not skipped at all) before IBM i is
supported.

PR-URL: #37035
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
  • Loading branch information
Trott authored and targos committed May 1, 2021
1 parent 8f580df commit 21e7b02
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/parallel/parallel.status
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,6 @@ test-tls-env-extra-ca: SKIP
# https://github.com/nodejs/node/pull/34209
test-dgram-error-message-address: SKIP
# https://github.com/nodejs/node/issues/36929
test-crypto-secure-heap: PASS,FLAKY
test-crypto-secure-heap: SKIP
# https://github.com/nodejs/node/issues/36925
test-fs-read-type: PASS,FLAKY
test-fs-read-type: SKIP

0 comments on commit 21e7b02

Please sign in to comment.