Skip to content

Commit 2141d37

Browse files
ctidejasnell
authored andcommitted
events: update and clarify error message
Update error message that's thrown when no error listeners are attached to an emitter. PR-URL: #10387 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
1 parent cfc8422 commit 2141d37

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

Diff for: lib/events.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ EventEmitter.prototype.emit = function emit(type) {
171171
er = arguments[1];
172172
if (domain) {
173173
if (!er)
174-
er = new Error('Uncaught, unspecified "error" event');
174+
er = new Error('Unhandled "error" event');
175175
if (typeof er === 'object' && er !== null) {
176176
er.domainEmitter = this;
177177
er.domain = domain;
@@ -182,7 +182,7 @@ EventEmitter.prototype.emit = function emit(type) {
182182
throw er; // Unhandled 'error' event
183183
} else {
184184
// At least give some kind of context to the user
185-
var err = new Error('Uncaught, unspecified "error" event. (' + er + ')');
185+
const err = new Error('Unhandled "error" event. (' + er + ')');
186186
err.context = er;
187187
throw err;
188188
}

Diff for: test/parallel/test-event-emitter-errors.js

+6-2
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@ const assert = require('assert');
55

66
const EE = new EventEmitter();
77

8-
assert.throws(function() {
8+
assert.throws(() => {
99
EE.emit('error', 'Accepts a string');
10-
}, /Accepts a string/);
10+
}, /^Error: Unhandled "error" event\. \(Accepts a string\)$/);
11+
12+
assert.throws(() => {
13+
EE.emit('error', {message: 'Error!'});
14+
}, /^Error: Unhandled "error" event\. \(\[object Object\]\)$/);

0 commit comments

Comments
 (0)