Skip to content

Commit 2010f43

Browse files
Tom AtkinsonMylesBorins
Tom Atkinson
authored andcommitted
crypto: fix memory leak if certificate is revoked
The additional validity checks applied to StartCom and WoSign certificates failed to free memory before returning. Refs: #9469 Fixes: #12033 PR-URL: #12089 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
1 parent b6941b0 commit 2010f43

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

src/node_crypto.cc

+6-2
Original file line numberDiff line numberDiff line change
@@ -2693,7 +2693,9 @@ inline bool CertIsStartComOrWoSign(X509_NAME* name) {
26932693
startcom_wosign_data = dn.data;
26942694
startcom_wosign_name = d2i_X509_NAME(nullptr, &startcom_wosign_data,
26952695
dn.len);
2696-
if (X509_NAME_cmp(name, startcom_wosign_name) == 0)
2696+
int cmp = X509_NAME_cmp(name, startcom_wosign_name);
2697+
X509_NAME_free(startcom_wosign_name);
2698+
if (cmp == 0)
26972699
return true;
26982700
}
26992701

@@ -2738,8 +2740,10 @@ inline CheckResult CheckWhitelistedServerCert(X509_STORE_CTX* ctx) {
27382740
}
27392741

27402742
X509* leaf_cert = sk_X509_value(chain, 0);
2741-
if (!CheckStartComOrWoSign(root_name, leaf_cert))
2743+
if (!CheckStartComOrWoSign(root_name, leaf_cert)) {
2744+
sk_X509_pop_free(chain, X509_free);
27422745
return CHECK_CERT_REVOKED;
2746+
}
27432747

27442748
// When the cert is issued from either CNNNIC ROOT CA or CNNNIC EV
27452749
// ROOT CA, check a hash of its leaf cert if it is in the whitelist.

0 commit comments

Comments
 (0)