From 1f16df21f8be60ac4e8cdc88f5adb5a3cf1a0ecb Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Thu, 20 Jul 2023 10:56:03 +0200 Subject: [PATCH] deps: V8: cherry-pick b33bf2dfd261 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Original commit message: Ignore --predictable when computing flag list hashes This allows reproducible code cache generation. Refs: https://github.com/nodejs/node/pull/48749 Change-Id: Ib4693de60ddff1fe41d95c10980f763463db3f95 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4681766 Reviewed-by: Leszek Swirski Commit-Queue: Joyee Cheung Cr-Commit-Position: refs/heads/main@{#88943} Refs: https://github.com/v8/v8/commit/b33bf2dfd26131cd51640b618853f2dfcfe5f728 PR-URL: https://github.com/nodejs/node/pull/49703 Refs: https://github.com/v8/v8/commit/de9a5de2274f483961a04a933d84abd81dee9c07 Reviewed-By: Jiawen Geng Reviewed-By: Michaël Zasso Reviewed-By: Richard Lau --- deps/v8/src/flags/flags.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/deps/v8/src/flags/flags.cc b/deps/v8/src/flags/flags.cc index e41b71f85ec657..f43715ac32eb0d 100644 --- a/deps/v8/src/flags/flags.cc +++ b/deps/v8/src/flags/flags.cc @@ -539,8 +539,10 @@ uint32_t ComputeFlagListHash() { // We want to be able to flip --profile-deserialization without // causing the code cache to get invalidated by this hash. if (flag.PointsTo(&v8_flags.profile_deserialization)) continue; - // Skip v8_flags.random_seed to allow predictable code caching. + // Skip v8_flags.random_seed and v8_flags.predictable to allow predictable + // code caching. if (flag.PointsTo(&v8_flags.random_seed)) continue; + if (flag.PointsTo(&v8_flags.predictable)) continue; modified_args_as_string << flag; } std::string args(modified_args_as_string.str());